Messages in this thread | | | Date | Sat, 24 Feb 2018 19:51:41 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] linux/kernel.h: break long lines |
| |
On Sat, Feb 24, 2018 at 01:45:30PM -0500, Theodore Ts'o wrote: > static inline int __must_check > kstrtou64_from_user(const char __user *s, size_t count, unsigned int base, u64 *res)
Yeah, had already typed that one in the reply but then opted for not mentioning it because it is a bit controversial with maintainers. :)
> Which yes, is still longer than 80 characters. But this is where > blindly following coding guidelines as if they are fundamentalist > biblical doctrine is not really a great idea. The goal is to make the > code easier to read, and very often it's important to apply _judgement_. > (Which is one of the reasons why I generally don't really like newbies > trying to apply checkpatch.pl to existing source files.)
That's basically what I was trying to say but your formulation is much better.
Thx.
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |