Messages in this thread | | | Date | Fri, 23 Feb 2018 18:30:53 +0530 | From | Aishwarya Pant <> | Subject | Re: [PATCH] acpi: nfit: document sysfs interface |
| |
On Wed, Feb 21, 2018 at 03:46:06PM -0800, Dan Williams wrote:
<snip>
> > So, this looks great and is something I've had on my backlog for a > while. That said this is a bit incomplete. These attributes are > relative to the the "nd" bus which is the libnvdimm sub-system sysfs > interface. This document describes that sysfs layout [3]. Ideally that > content would be converted into Documentation/ABI format and merged > with what you have done here into an overall > Documentation/ABI/testing/sysfs-bus-nvdimm file. > > I realize that's quite a bit more work, so I'm fine if we start with > the nfit attributes and save that follow on work for a separate patch > in the future.
Thanks for the review!
I'll keep the libnvdim interface in my backlog for now. I just sent a revision of the nfit patch with the suggested changes.
Aishwarya
> > [3]: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/tree/Documentation/nvdimm/nvdimm.txt?h=libnvdimm-for-next
| |