lkml.org 
[lkml]   [2018]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 20/20] x86/PCI: VMD: Fix malformed Kconfig default
On Thu, Feb 22, 2018 at 06:21:42PM -0600, Bjorn Helgaas wrote:
> On Fri, Feb 23, 2018 at 12:42:28AM +0100, Ulf Magnusson wrote:
> > On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> > > On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> > >> 'default N' should be 'default n', though they happen to have the same
> > >> effect here, due to undefined symbols (N in this case) evaluating to n
> > >> in a tristate sense.
> > >>
> > >> Remove the default instead of changing it. bool and tristate symbols
> > >> implicitly default to n.
> > >
> > > s/bool/Bool/
> >
> > Not a great excuse, but I was thinking syntactically -- 'bool' and
> > 'tristate' symbols... :)
> >
> > >
> > >> Discovered with the
> > >> https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py
> > >> script.
> > >>
> > >> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> > >
> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > >
> > > Since only this patch was posted to linux-pci, I assume it will be merged
> > > via some other tree.
> >
> > I didn't have a particular tree in mind for this patchset. I imagined
> > people would pick up patches into the trees where they make the most
> > sense, and only created the patchset to keep track of the patches more
> > easily. Might have created some confusion in retrospect.
> >
> > I just did a --cc-cmd="scripts/get_maintainer.pl -i" for the
> > individual patches by the way.
>
> OK, then either Lorenzo or I will pick it up.
>
> It's in drivers/pci/host/, so ideally Lorenzo will take it since he
> looks after everything else in there.

Sure I will take it, thanks.

Lorenzo

\
 
 \ /
  Last update: 2018-02-23 11:35    [W:0.038 / U:3.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site