Messages in this thread | | | Subject | Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning | From | Eric Dumazet <> | Date | Thu, 22 Feb 2018 08:40:25 -0800 |
| |
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote:
... > > This code is old, so Cc stable to make sure that we don't get the warning > for older kernels built with new gcc. > > Cc: stable@vger.kernel.org
This part makes little sense to me for two reasons.
1) David Miller handles stable submission himself ( Documentation/networking/netdev-FAQ.txt )
2) We are not supposed to make sure old kernels will compile with future compilers.
That would need a lot of work and potential new bugs, not worth the time.
Otherwise your patch looks fine really ;)
| |