lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH NAND v3] mtd: nand: Replace printk() with appropriate pr_*() macro
    On Thu, 22 Feb 2018 20:15:58 +0530
    Shreeya Patel <shreeya.patel23498@gmail.com> wrote:

    > On Thu, 2018-02-22 at 15:30 +0100, Richard Weinberger wrote:
    > > Am Donnerstag, 22. Februar 2018, 14:10:14 CET schrieb Shreeya Patel:
    > > >
    > > > @@ -438,7 +438,7 @@ static void __init doc2000_count_chips(struct
    > > > mtd_info
    > > > *mtd) break;
    > > >   }
    > > >   doc->chips_per_floor = i;
    > > > - printk(KERN_DEBUG "Detected %d chips per floor.\n", i);
    > > > + pr_debug("Detected %d chips per floor.\n", i);
    > > <bike-shedding>
    > >
    > > You are aware of the fact that printk(KERN_DEBUG and pr_debug() are
    > > not 
    > > equivalent?
    > > Not a big deal, just want to make sure that you understand what you
    > > are doing. 
    >
    > Actually pr_debug() shouldn't be used here.
    >
    > We usually don't prefer pr_debug for drivers, instead we use dev_dbg.
    > But as Boris told me that it will be better to first having changed all
    > printks to pr_*() macro and then think about dev_*() macros.

    pr_xx() vs dev_xx() is yet another story ;-).

    --
    Boris Brezillon, Bootlin (formerly Free Electrons)
    Embedded Linux and Kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2018-02-22 15:51    [W:4.283 / U:0.572 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site