lkml.org 
[lkml]   [2018]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 5/6] ARM: dts: stm32: add joystick support on stm32746g-eval
    Hi Amelie,

    thanks for your patch.

    On Thu, Feb 8, 2018 at 3:27 PM, Amelie Delaunay <amelie.delaunay@st.com> wrote:

    > The joystick on stm32746g-eval uses gpios on MFX gpio expander.
    >
    > Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
    (...)
    > + joystick {
    > + compatible = "gpio-keys";
    > + #address-cells = <1>;
    > + #size-cells = <0>;
    > + button@1 {
    > + label = "JoySel";
    > + linux,code = <KEY_ENTER>;
    > + gpios = <&mfxgpio 0 (GPIO_ACTIVE_LOW | GPIO_IN_PUSH_PULL | GPIO_PULL_UP)>;
    > + };

    As I think this should not all be handled by GPIO, the joystick on
    gpio-keys needs a pin control handle pointing back to pin control
    states on the respective pins in the pin control/GPIO driver,
    where it can set up these properties.

    For the individual lines the pushing and pulling flags should be
    removed.

    Yours,
    Linus Walleij

    \
     
     \ /
      Last update: 2018-02-22 14:53    [W:3.428 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site