Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 21 Feb 2018 16:22:06 -0800 | Subject | Re: RANDSTRUCT structs need linux/compiler_types.h (Was: [nfsd4] potentially hardware breaking regression in 4.14-rc and 4.13.11) |
| |
On Wed, Feb 21, 2018 at 4:12 PM, Kees Cook <keescook@chromium.org> wrote: > > Do you want me to send the patch for this, or do you already have it > prepared?
I'd rather get something explicitly tested. I tried my earlier patch with "make allmodconfig" (and a fix to nfsd to make it compile), but now I'm back to testing hjl's gas updates so it would be better to get a tested commit with a good commit message.
> The body-fields I had prepared for the nfs were: > > Reported-by: Patrick McLean <chutzpah@gentoo.org> > Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Oh, I think Maciej needs to get more than a "Reported-by:". This was a really subtle thing that we didn't figure out in the original thread, so give him a gold star in the form of "Root-caused-by:" or something.
*Fixing* this ends up being a one-liner or so. Finding the cause was the painful part.
Linus
| |