lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 052/100] rtc: pcf2123: stop validating rtc_time in .read_time
    Date
    The RTC core is always calling rtc_valid_tm after the read_time callback.
    It is not necessary to call it just before returning from the callback.

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-pcf2123.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c
    index 8895f77726e8..e5222c5d8223 100644
    --- a/drivers/rtc/rtc-pcf2123.c
    +++ b/drivers/rtc/rtc-pcf2123.c
    @@ -289,7 +289,7 @@ static int pcf2123_rtc_read_time(struct device *dev, struct rtc_time *tm)
    tm->tm_sec, tm->tm_min, tm->tm_hour,
    tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday);

    - return rtc_valid_tm(tm);
    + return 0;
    }

    static int pcf2123_rtc_set_time(struct device *dev, struct rtc_time *tm)
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-21 22:14    [W:4.165 / U:1.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site