lkml.org 
[lkml]   [2018]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 012/100] rtc: coh901331: stop validating rtc_time in .read_time
    Date
    rtc_time_to_tm never generates an invalid tm. It is not necessary to
    validate it. Also, the RTC core is always calling rtc_valid_tm after the
    read_time callback.

    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    ---
    drivers/rtc/rtc-coh901331.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c
    index cfc4141d99cd..2fc517498a5d 100644
    --- a/drivers/rtc/rtc-coh901331.c
    +++ b/drivers/rtc/rtc-coh901331.c
    @@ -82,7 +82,7 @@ static int coh901331_read_time(struct device *dev, struct rtc_time *tm)
    if (readl(rtap->virtbase + COH901331_VALID)) {
    rtc_time_to_tm(readl(rtap->virtbase + COH901331_CUR_TIME), tm);
    clk_disable(rtap->clk);
    - return rtc_valid_tm(tm);
    + return 0;
    }
    clk_disable(rtap->clk);
    return -EINVAL;
    --
    2.16.1
    \
     
     \ /
      Last update: 2018-02-21 21:57    [W:2.820 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site