lkml.org 
[lkml]   [2018]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()"
On Fri, Feb 02, 2018 at 10:39:04AM -0800, Eric Dumazet wrote:
> On Fri, 2018-02-02 at 18:06 +0000, Roman Gushchin wrote:
> >
> > Idk, how even we can hit it? And if so, what scary will happen?
> >
> > If you prefer to have it there, I definitely can return it,
> > but I see no profit so far.
>
> I was simply curious this was not mentioned in the changelog.
>
> A revert is normally a true revert, modulo the changes needed by
> conflicts and possible changes.
>
> I personally do not care of this BUG_ON(), I had not put it in the
> first place.

Technically it's not a true revert, but you're totally right.
Let me add a note to the commit description.

Are you ok with the rest?

Thanks!

\
 
 \ /
  Last update: 2018-02-02 20:08    [W:0.048 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site