lkml.org 
[lkml]   [2018]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v3,02/11] watchdog/hpwdt: remove include files no longer needed.
    On Thu, Feb 15, 2018 at 04:43:51PM -0700, Jerry Hoemann wrote:
    > Remove header files used by NMI sourcing and DMI decoding.
    >
    > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>

    This patch should have been merged with the 1st patch of the series,
    since it is logically the same change. However, that does not raise
    to the level of objection.

    Reviewed-by: Guenter Roeck <linux@roeck-us.net>

    > ---
    > drivers/watchdog/hpwdt.c | 9 ---------
    > 1 file changed, 9 deletions(-)
    >
    > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
    > index 113058644fc3..20a13c5d0285 100644
    > --- a/drivers/watchdog/hpwdt.c
    > +++ b/drivers/watchdog/hpwdt.c
    > @@ -28,16 +28,7 @@
    > #include <linux/types.h>
    > #include <linux/uaccess.h>
    > #include <linux/watchdog.h>
    > -#ifdef CONFIG_HPWDT_NMI_DECODING
    > -#include <linux/dmi.h>
    > -#include <linux/spinlock.h>
    > -#include <linux/nmi.h>
    > -#include <linux/kdebug.h>
    > -#include <linux/notifier.h>
    > -#include <asm/set_memory.h>
    > -#endif /* CONFIG_HPWDT_NMI_DECODING */
    > #include <asm/nmi.h>
    > -#include <asm/frame.h>
    >
    > #define HPWDT_VERSION "1.4.0"
    > #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128)

    \
     
     \ /
      Last update: 2018-02-17 17:10    [W:2.552 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site