Messages in this thread | | | Date | Fri, 16 Feb 2018 09:45:28 -0800 (PST) | From | Liam Mark <> | Subject | Re: [PATCH] staging: android: ion: Initialize dma_address of new sg list |
| |
On Thu, 15 Feb 2018, Laura Abbott wrote:
> On 02/12/2018 01:25 PM, Liam Mark wrote: > > > > On Mon, 12 Feb 2018, Dan Carpenter wrote: > > > > > On Fri, Feb 09, 2018 at 10:16:56PM -0800, Liam Mark wrote: > > > > Fix the dup_sg_table function to initialize the dma_address of the new > > > > sg list entries instead of the source dma_address entries. > > > > > > > > Fixes: 17fd283f3870 ("staging: android: ion: Duplicate sg_table") > > > > Signed-off-by: Liam Mark <lmark@codeaurora.org> > > > > > > How did you find this bug? What are the user visible effects of this > > > bug? I'm probably going to ask you to send a v2 patch with a new > > > changelog depending on the answers to these questions. > > > > I noticed the bug when reading through the code, I haven?t seen any > > visible effects of this bug. > > > > From looking at the code I don?t see any obvious ways that this bug > would > > introduce any issues with the current code base. > > > > Liam > > > > Given the way we duplicate the sg_list this should be harmless but you > are right it's cleaner if we initialize the new list. You can add my > Ack when you update with a new change log clarifying this. > > Thanks, > Laura >
Will do.
Thanks, Liam
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |