Messages in this thread Patch in this message | | | Subject | [PATCH 2/3] pata_macio: Improve a size determination in two functions | From | SF Markus Elfring <> | Date | Fri, 16 Feb 2018 13:39:35 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 16 Feb 2018 13:08:14 +0100
Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/ata/pata_macio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c index 9588e685d994..dc40af4c615c 100644 --- a/drivers/ata/pata_macio.c +++ b/drivers/ata/pata_macio.c @@ -1129,8 +1129,7 @@ static int pata_macio_attach(struct macio_dev *mdev, macio_enable_devres(mdev); /* Allocate and init private data structure */ - priv = devm_kzalloc(&mdev->ofdev.dev, - sizeof(struct pata_macio_priv), GFP_KERNEL); + priv = devm_kzalloc(&mdev->ofdev.dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; @@ -1273,8 +1272,7 @@ static int pata_macio_pci_attach(struct pci_dev *pdev, } /* Allocate and init private data structure */ - priv = devm_kzalloc(&pdev->dev, - sizeof(struct pata_macio_priv), GFP_KERNEL); + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; -- 2.16.1
| |