Messages in this thread | | | From | Philippe Ombredanne <> | Date | Fri, 16 Feb 2018 13:33:53 +0100 | Subject | Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree |
| |
Mikko,
On Thu, Feb 15, 2018 at 3:52 PM, Mikko Perttunen <mperttunen@nvidia.com> wrote: > Add the chip-level device tree, including binding headers, for the > NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices > are initially available, enough to boot to UART console. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> > --- > > Notes: > v3: > - added hypervisor-related apertures to GIC node > - removed GPL boilerplate in favor of SPDX and harmonized > copyright headers
Thanks for this boilerplate removal! but see a few nits below.
<snip>
> --- /dev/null > +++ b/include/dt-bindings/clock/tegra194-clock.h > @@ -0,0 +1,653 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */
The proper style should be this for a .h header on the first line per [1]
> +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + */
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
<snip>
> --- /dev/null > +++ b/include/dt-bindings/gpio/tegra194-gpio.h > @@ -0,0 +1,64 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > +
<snip>
Same as above
> --- /dev/null > +++ b/include/dt-bindings/power/tegra194-powergate.h > @@ -0,0 +1,38 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */
<snip>
Same as above
> --- /dev/null > +++ b/include/dt-bindings/reset/tegra194-reset.h > @@ -0,0 +1,155 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */
<snip>
Same as above -- Cordially Philippe Ombredanne
| |