Messages in this thread | | | From | Philippe Ombredanne <> | Date | Thu, 15 Feb 2018 10:50:22 +0100 | Subject | Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec |
| |
Dear Sebastian,
On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel <sebastian.reichel@collabora.co.uk> wrote: > Motorola CPCAP is a PMIC with audio functionality, that can be > found on Motorola Droid 4 and probably a few other phones from > Motorola's Droid series. > > The driver has been written from scratch using Motorola's Android > driver, register dumps from running Android and datasheet for NXP > MC13783UG (which is similar to Motorola CPCAP, but not the same). > > The chip provides two audio interfaces, that can be muxed to two > different audio codecs. One provides support for stereo output > (named StDAC or HiFi), while the other only provides mono output > (named Voice). Only the Voice codec provides a Capture interface. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
<snip>
> --- /dev/null > +++ b/sound/soc/codecs/cpcap.c > @@ -0,0 +1,1588 @@ > +/* > + * ALSA SoC CPCAP codec driver > + * > + * Copyright (C) 2017 - 2018 Sebastian Reichel <sre@kernel.org> > + * > + * Very loosely based on original driver from Motorola: > + * Copyright (C) 2007 - 2009 Motorola, Inc. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + */
Could you consider using the new SPDX tags instead of this fine but long legalese? [1]
<snip>
> +MODULE_ALIAS("platform:cpcap-codec"); > +MODULE_DESCRIPTION("ASoC CPCAP codec driver"); > +MODULE_AUTHOR("Sebastian Reichel"); > +MODULE_LICENSE("GPL");
This does not match your license: per module.h, GPL means GPL-2.0 or later. You notice above is GPL-2.0, not "or later"
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- Cordially Philippe Ombredanne
| |