Messages in this thread | | | Subject | Re: [PATCH v2] ASoC: rt5645: Introduce mapping for ACPI-defined GPIO | From | Hans de Goede <> | Date | Thu, 15 Feb 2018 10:17:45 +0100 |
| |
Hi,
On 15-02-18 10:11, Carlo Caione wrote: > On Fri, Feb 9, 2018 at 2:23 PM, Carlo Caione <carlo@caione.org> wrote: >> From: Carlo Caione <carlo@endlessm.com> >> >> On at least one notebook (ECS EF20EA) the 'hp-detect' GPIO is defined in >> the DSDT table by the ACPI GpioIo resources in _CRS. Add this mapping to >> the rt5645 driver to enable the jack detection also on non-DT platforms. > > Please do not merge this yet, I'll submit a V3 soon. > Hans pointed out that on some BayTrail there is indeed an extra GPIO > but it is used to enable the external speaker amplifier. Better to > guard this by a quirk.
Thank you Carlo, note that the tablet I was talking about is a rt5651 based tablet, but yes you never know for what reasons someone will put an extra GPIO in the resources table, so guarding this with a quirk seems like a good idea.
Regards,
Hans
| |