Messages in this thread | | | Date | Thu, 15 Feb 2018 17:50:28 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed |
| |
On Thu, Feb 15, 2018 at 03:22:47PM +0000, Patrick Bellasi wrote: > > > static struct { > > > cpumask_var_t idle_cpus_mask; > > > atomic_t nr_cpus; > > > + int has_blocked; /* Idle CPUS has blocked load */ > > Why not "bool"? > Because then he gets me yelling that sizeof(_Bool) is undefined and the whole structure layout goes out the window :-)
Never use bool in a composite type.
| |