lkml.org 
[lkml]   [2018]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.15 124/202] media: v4l2-compat-ioctl32.c: dont copy back the result for certain errors
    Date
    4.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Hans Verkuil <hans.verkuil@cisco.com>

    commit d83a8243aaefe62ace433e4384a4f077bed86acb upstream.

    Some ioctls need to copy back the result even if the ioctl returned
    an error. However, don't do this for the error code -ENOTTY.
    It makes no sense in that cases.

    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
    +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
    @@ -968,6 +968,9 @@ static long do_video_ioctl(struct file *
    set_fs(old_fs);
    }

    + if (err == -ENOTTY)
    + return err;
    +
    /* Special case: even after an error we need to put the
    results back for these ioctls since the error_idx will
    contain information on which control failed. */

    \
     
     \ /
      Last update: 2018-02-15 17:03    [W:3.796 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site