Messages in this thread | | | Subject | Re: [PATCH 1/2] pps-gpio: Avoid flooding syslog | From | Rodolfo Giometti <> | Date | Thu, 15 Feb 2018 16:36:25 +0100 |
| |
On 15/02/18 16:12, Lukas Senger wrote: > >> Why a void function? You should use it to toggle echoing GPIO... =8-o > > RFC 2783 says to generate the echo pulse "as rapidly as possible" which > is why I do the toggling in the irq handler. However this leaves the > default echo function installed which just floods syslog.
The pps_event() function does it for you in a beauty-and-clear way by using the info.echo() function. :-D
> Another problem with this patch is that it also is against my old one > and not against current kernel code.
Yes, correct it please.
Ciao,
Rodolfo
--
HCE Engineering e-mail: giometti@hce-engineering.it GNU/Linux Solutions giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.it Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
| |