lkml.org 
[lkml]   [2018]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v3 00/11] watchdog/hpwdt: Update driver to use watchdog core.
    Date
    == v3 ==

    Incorperating code review feedback. Following modifications were made:

    1) Patch 0003: Use existing hex_byte_pack instead of creating new function.
    2) Patch 0005: Redacted change in module_param permission.
    3) Patch 0006: switch from pr_debug etc., to dev_dbg where possible.
    4) Patch 0006: No longer updating soft_margin post module load.
    5) Patch 0006: Initialize hpwdt_dev.parent before registering watchdog.
    6) Patch 0006: Redacted change to dev_info message w.r.t. allow_kdump
    7) Patch 0006 & 0007: Reorder patches to maintain bisectability.
    8) Patch 0008: Change pr_debug to dev_dbg
    9) Patch 0010: Change dev_info message w.r.t. allow_kdump where feature
    is removed.

    Note, I am explicitly ignoring the checkpatch error on Patch 0008
    for specifying permisson of "0" instead of "0000".


    == v2 ==

    1) Fix compiler error when CONFIG_HPWDT_NMI_DECODING is not defined.

    2) Break out driver version change to its own patch (0011).


    == v1 ==

    The primary purposes of this patch set are to

    1) Update the hpwdt driver to use the watchdog core.
    2) Reduce complexity by removing unnecessary features.
    3) Add customer requested features like optional pretimeout.
    4) Enhance readability/maintainability of the driver.

    The size of the resultant driver is reduced from over 900
    lines to 350 lines.

    Patch 1& 2 remove legacy NMI sourcing.
    Patch 3 adds useful indication of NMI cause to panic message
    Patch 4 & 5 are general cleanup
    Patch 6 & 7 updates the driver to user the watchdog core.
    Patch 8 makes the pretimeout NMI programmable.
    Patch 9 modifies whether the NMI handler claims the NMI.
    Patch 10 retracts the allow_kdump module parameter.



    Jerry Hoemann (11):
    watchdog/hpwdt: Remove legacy NMI sourcing.
    watchdog/hpwdt: remove include files no longer needed.
    watchdog/hpwdt: Update nmi_panic message.
    watchdog/hpwdt: white space changes
    watchdog/hpwdt: Update Module info.
    watchdog/hpwdt: Select WATCHDOG_CORE
    watchdog/hpwdt: Modify to use watchdog core.
    watchdog/hpwdt: Programable Pretimeout NMI
    watchdog/hpwdt: condition early return of NMI handler on iLO5
    watchdog/hpwdt: remove allow_kdump module parameter.
    watchdog/hpwdt: Update driver version.

    drivers/watchdog/Kconfig | 1 +
    drivers/watchdog/hpwdt.c | 845 ++++++++---------------------------------------
    2 files changed, 134 insertions(+), 712 deletions(-)

    --
    2.13.6

    \
     
     \ /
      Last update: 2018-02-16 00:46    [W:8.514 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site