lkml.org 
[lkml]   [2018]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/char/tpm/tpm_eventlog_efi.c:53:23-30: WARNING opportunity for kmemdep
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 61f14c015f5be9151ba25e638d349f4d40cb7cd4
commit: 58cc1e4faf10a73c4302825ffd37a47d410fc1b5 tpm: parse TPM event logs based on EFI table
date: 5 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/char/tpm/tpm_eventlog_efi.c:53:23-30: WARNING opportunity for kmemdep

vim +53 drivers/char/tpm/tpm_eventlog_efi.c

22
23 struct linux_efi_tpm_eventlog *log_tbl;
24 struct tpm_bios_log *log;
25 u32 log_size;
26 u8 tpm_log_version;
27
28 if (!(chip->flags & TPM_CHIP_FLAG_TPM2))
29 return -ENODEV;
30
31 if (efi.tpm_log == EFI_INVALID_TABLE_ADDR)
32 return -ENODEV;
33
34 log = &chip->log;
35
36 log_tbl = memremap(efi.tpm_log, sizeof(*log_tbl), MEMREMAP_WB);
37 if (!log_tbl) {
38 pr_err("Could not map UEFI TPM log table !\n");
39 return -ENOMEM;
40 }
41
42 log_size = log_tbl->size;
43 memunmap(log_tbl);
44
45 log_tbl = memremap(efi.tpm_log, sizeof(*log_tbl) + log_size,
46 MEMREMAP_WB);
47 if (!log_tbl) {
48 pr_err("Could not map UEFI TPM log table payload!\n");
49 return -ENOMEM;
50 }
51
52 /* malloc EventLog space */
> 53 log->bios_event_log = kmalloc(log_size, GFP_KERNEL);

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

\
 
 \ /
  Last update: 2018-02-14 15:55    [W:0.042 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site