lkml.org 
[lkml]   [2018]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU
On Wed, Feb 14, 2018 at 7:03 PM, Vivek Gautam
<vivek.gautam@codeaurora.org> wrote:
>
>
> On 1/24/2018 7:19 PM, Robin Murphy wrote:
>>
>> On 24/01/18 10:35, Jeffy Chen wrote:
>>>
>>> From: Tomasz Figa <tfiga@chromium.org>
>>>
>>> Current code relies on master driver enabling necessary clocks before
>>> IOMMU is accessed, however there are cases when the IOMMU should be
>>> accessed while the master is not running yet, for example allocating
>>> V4L2 videobuf2 buffers, which is done by the VB2 framework using DMA
>>> mapping API and doesn't engage the master driver at all.
>>>
>>> This patch fixes the problem by letting clocks needed for IOMMU
>>> operation to be listed in Device Tree and making the driver enable them
>>> for the time of accessing the hardware.
>>>
>>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>>> Signed-off-by: Tomasz Figa <tfiga@chromium.org>
>>> ---
>>>
>>> Changes in v5:
>>> Use clk_bulk APIs.
>>>
>>> Changes in v4: None
>>> Changes in v3: None
>>> Changes in v2: None
>
>
> [snip]
>
>
>>> +static int rk_iommu_of_get_clocks(struct rk_iommu *iommu)
>>> +{
>>> + struct device_node *np = iommu->dev->of_node;
>>> + int ret;
>>> + int i;
>>> +
>>> + ret = of_count_phandle_with_args(np, "clocks", "#clock-cells");
>>> + if (ret == -ENOENT)
>>> + return 0;
>>> + else if (ret < 0)
>>> + return ret;
>>> +
>>> + iommu->num_clocks = ret;
>>> + iommu->clocks = devm_kcalloc(iommu->dev, iommu->num_clocks,
>>> + sizeof(*iommu->clocks), GFP_KERNEL);
>>> + if (!iommu->clocks)
>>> + return -ENOMEM;
>>> +
>>> + for (i = 0; i < iommu->num_clocks; ++i) {
>>> + iommu->clocks[i].clk = of_clk_get(np, i);
>>> + if (IS_ERR(iommu->clocks[i].clk)) {
>>> + ret = PTR_ERR(iommu->clocks[i].clk);
>>> + goto err_clk_put;
>>> + }
>>> + }
>>
>>
>> Just to confirm my understanding from a quick scan through the code, the
>> reason we can't use clk_bulk_get() here is that currently, clocks[i].id
>> being NULL means we'd end up just getting the first clock multiple times,
>> right?
>>
>> I guess there could be other users who also want "just get whatever clocks
>> I have" functionality, so it might be worth proposing that for the core API
>> as a separate/follow-up patch, but it definitely doesn't need to be part of
>> this series.
>
>
> Just to understand. Is it okay to make the driver "just get whatever clocks
> device node gives"?
> Doesn't the driver need to be aware of which all clocks are supposed to be
> obtained and enabled
> It's should good for debug to let the world know which clock we failed to
> get.

Yeah, in general that's desired. However, it is at least impractical
to specify all the clocks in Rockchip case, because it's different for
each block and depends on the master next to which it is located.

Best regards,
Tomasz

\
 
 \ /
  Last update: 2018-02-14 12:28    [W:0.058 / U:0.148 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site