lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 05/11] watchdog/hpwdt: Update Module info.
    On Sun, Feb 11, 2018 at 10:21:05PM -0700, Jerry Hoemann wrote:
    > Update Module Author and permission on parameters so that the
    > parameters show up in sysfs.
    >

    Does it really add value to see the module parameters in sysfs ?
    You would get both in standardized form by enabling WATCHDOG_SYSFS.

    > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
    > ---
    > drivers/watchdog/hpwdt.c | 10 +++++-----
    > 1 file changed, 5 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
    > index ee9a92220ece..dead59f9ca80 100644
    > --- a/drivers/watchdog/hpwdt.c
    > +++ b/drivers/watchdog/hpwdt.c
    > @@ -432,20 +432,20 @@ static struct pci_driver hpwdt_driver = {
    > .remove = hpwdt_exit,
    > };
    >
    > -MODULE_AUTHOR("Tom Mingarelli");
    > -MODULE_DESCRIPTION("hp watchdog driver");
    > +MODULE_AUTHOR("Jerry Hoemann");
    > +MODULE_DESCRIPTION("hpe watchdog driver");
    > MODULE_LICENSE("GPL");
    > MODULE_VERSION(HPWDT_VERSION);
    >
    > -module_param(soft_margin, int, 0);
    > +module_param(soft_margin, int, 0444);
    > MODULE_PARM_DESC(soft_margin, "Watchdog timeout in seconds");
    >
    > -module_param(nowayout, bool, 0);
    > +module_param(nowayout, bool, 0444);
    > MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
    > __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
    >
    > #ifdef CONFIG_HPWDT_NMI_DECODING /* { */
    > -module_param(allow_kdump, int, 0);
    > +module_param(allow_kdump, int, 0444);
    > MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
    > #endif /* } */
    >
    > --
    > 2.13.6
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    \
     
     \ /
      Last update: 2018-02-13 18:50    [W:6.025 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site