lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] nvme: implement log page low/high offset and dwords
From
Date
On 02/13/2018 02:47 PM, Johannes Thumshirn wrote:
> On Tue, 2018-02-13 at 13:49 +0100, Matias Bjørling wrote:
>> +int nvme_get_log_ext(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>> +     u8 log_page, void *log,
>> +     size_t size, size_t offset)
>> +{
>> + struct nvme_command c = { };
>> + unsigned long dwlen = (size / 4) - 1;
>
> Consulting my long gone maths knowledge suggests the parantheses aren't
> really needed here.
>

Heh, you're right. However, it does make it a bit more readable? The
untrained eye would properly mess it up was my thinking for keeping them.

\
 
 \ /
  Last update: 2018-02-13 14:53    [W:0.046 / U:25.260 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site