lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/entry/64: Remove unused icebp macro

* Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Feb 12, 2018 at 02:18:55AM -0800, tip-bot for Dominik Brodowski wrote:
> > Commit-ID: 5a10e729bc0aa9420a23a70b169eadd229c27bc1
> > Gitweb: https://git.kernel.org/tip/5a10e729bc0aa9420a23a70b169eadd229c27bc1
> > Author: Dominik Brodowski <linux@dominikbrodowski.net>
> > AuthorDate: Sun, 11 Feb 2018 11:49:48 +0100
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Mon, 12 Feb 2018 08:06:37 +0100
> >
> > x86/entry/64: Indent PUSH_AND_CLEAR_REGS and POP_REGS properly
>
> Ontop:
>
> ---
> From: Borislav Petkov <bp@suse.de>
>
> That macro was touched around 2.5.8 times, judging by the full history
> linux repo, but it was unused even then. Get rid of it already.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> arch/x86/entry/calling.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 6985440c68fa..dce7092ab24a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -159,10 +159,6 @@ For 32-bit we have the following conventions - kernel is built with
> .if \pop_rdi
> popq %rdi
> .endif
> - .endm
> -
> - .macro icebp
> - .byte 0xf1
> .endm

Good find!

I applied this separately, and added your SOB: let me know if that's not OK.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-02-13 08:36    [W:0.068 / U:0.664 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site