lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel/sched/cpudeadline: Fixed code style errors and warnings

* Mario Leinweber <marioleinweber@web.de> wrote:

> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
> index 8d9562d890d3..6a9defebbb54 100644
> --- a/kernel/sched/cpudeadline.c
> +++ b/kernel/sched/cpudeadline.c
> @@ -42,8 +42,9 @@ static void cpudl_heapify_down(struct cpudl *cp, int idx)
> return;
>
> /* adapted from lib/prio_heap.c */
> - while(1) {
> + while (1) {
> u64 largest_dl;
> +
> l = left_child(idx);
> r = right_child(idx);
> largest = idx;
> @@ -131,6 +132,7 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p,
> return 1;
> } else {
> int best_cpu = cpudl_maximum(cp);
> +
> WARN_ON(best_cpu != -1 && !cpu_present(best_cpu));
>
> if (cpumask_test_cpu(best_cpu, &p->cpus_allowed) &&
> @@ -205,6 +207,7 @@ void cpudl_set(struct cpudl *cp, int cpu, u64 dl)
> old_idx = cp->elements[cpu].idx;
> if (old_idx == IDX_INVALID) {
> int new_idx = cp->size++;
> +
> cp->elements[new_idx].dl = dl;
> cp->elements[new_idx].cpu = cpu;
> cp->elements[cpu].idx = new_idx;

Your Signed-off-by tag is missing.

Thanks,

Ingo

\
 
 \ /
  Last update: 2018-02-13 13:28    [W:0.033 / U:0.260 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site