lkml.org 
[lkml]   [2018]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: samples/seccomp/ broken when cross compiling s390, ppc allyesconfig
    Date
    Kees Cook <keescook@chromium.org> writes:

    > On Mon, Feb 12, 2018 at 7:25 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
    >> Michal Hocko <mhocko@kernel.org> writes:
    >>> Hi,
    >>> my build test machinery chokes on samples/seccomp when cross compiling
    >>> s390 and ppc64 allyesconfig. This has been the case for quite some
    >>> time already but I never found time to look at the problem and report
    >>> it. It seems this is not new issue and similar thing happend for
    >>> MIPS e9107f88c985 ("samples/seccomp/Makefile: do not build tests if
    >>> cross-compiling for MIPS").
    >>>
    >>> The build logs are attached.
    >>>
    >>> What is the best way around this? Should we simply skip compilation on
    >>> cross compile or is actually anybody relying on that? Or should I simply
    >>> disable it for s390 and ppc?
    >>
    >> The whole thing seems very confused. It's not building for the target,
    >> it's building for the host, ie. the Makefile sets hostprogs-m and
    >> HOSTCFLAGS etc.
    >>
    >> So it can't possibly work with cross compiling as it's currently
    >> written.
    >>
    >> Either the Makefile needs some serious work to properly support cross
    >> compiling or it should just be disabled when cross compiling.
    >
    > Hrm, yeah, the goal was to entirely disable cross compiling, but I
    > guess we didn't hit it with a hard enough hammer. :)

    Do you know why it is written that way? Why doesn't it just try to cross
    compile like normal code?

    cheers

    \
     
     \ /
      Last update: 2018-02-13 11:18    [W:3.221 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site