Messages in this thread | | | Subject | Re: [PATCH 2/2] arm64: dts: juno: Describe the full GICv2m region | From | Marc Zyngier <> | Date | Mon, 12 Feb 2018 18:27:42 +0000 |
| |
Hi Sudeep,
On 12/02/18 18:17, Sudeep Holla wrote: > > > On 07/02/18 14:32, Marc Zyngier wrote: >> From: Robin Murphy <robin.murphy@arm.com> >> >> Juno's GICv2m implementation consists of four frames providing 32 >> interrupts each. Since it is possible to plug in enough PCIe endpoints >> to consume more than 32 MSIs, and the driver already has a bodge to >> handle multiple frames, let's expose the other three as well. >> > > Change on it own looks good. So if you want to merge via your tree: > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > Let me know if you decide not to take it via your tree and you want me > to send it to arm-soc.
If this would usually go via arm-soc, feel free to take it via this route. I'll drop the patch from my tree.
> On the side note I just noticed the Juno TRM[1] has 64k for each of > these MSI frames(page 3-24 section 3.3.5 Application memory map summary) > > I am not sure if TRM is wrong. This patch is just copying the 4k size > from frame 0 which got added with initial Juno DTS.
I can't see why the TRM would be wrong. This is actually consistent with the expected practice of aligning all devices on a 64kB boundary and size so that you don't get any nasty surprise when passing the device to a VM (*cough* GIC400 *cough*).
Robin, any chance you could check this?
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |