lkml.org 
[lkml]   [2018]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing/power: Don't share template for cpu_idle and cpu_frequency
Hi Changbin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.16-rc1 next-20180212]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/changbin-du-intel-com/tracing-power-Don-t-share-template-for-cpu_idle-and-cpu_frequency/20180212-224719
config: i386-randconfig-i1-201806 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/trace/define_trace.h:96:0,
from include/trace/events/power.h:516,
from kernel/trace/power-traces.c:15:
include/trace/events/power.h: In function 'trace_raw_output_cpu_frequency':
>> include/trace/events/power.h:153:12: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'u32 {aka unsigned int}' [-Wformat=]
TP_printk("frequency=%lu cpu_id=%lu", __entry->frequency,
^
include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^~~~~
include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
PARAMS(print)); \
^~~~~~
include/trace/events/power.h:137:1: note: in expansion of macro 'TRACE_EVENT'
TRACE_EVENT(cpu_frequency,
^~~~~~~~~~~
include/trace/events/power.h:153:2: note: in expansion of macro 'TP_printk'
TP_printk("frequency=%lu cpu_id=%lu", __entry->frequency,
^~~~~~~~~
In file included from include/trace/trace_events.h:394:0,
from include/trace/define_trace.h:96,
from include/trace/events/power.h:516,
from kernel/trace/power-traces.c:15:
include/trace/events/power.h:153:25: note: format string is defined here
TP_printk("frequency=%lu cpu_id=%lu", __entry->frequency,
~~^
%u

vim +153 include/trace/events/power.h

138
139 TP_PROTO(unsigned int frequency, unsigned int cpu_id),
140
141 TP_ARGS(frequency, cpu_id),
142
143 TP_STRUCT__entry(
144 __field( u32, frequency )
145 __field( u32, cpu_id )
146 ),
147
148 TP_fast_assign(
149 __entry->frequency = frequency;
150 __entry->cpu_id = cpu_id;
151 ),
152
> 153 TP_printk("frequency=%lu cpu_id=%lu", __entry->frequency,
154 (unsigned long)__entry->cpu_id)
155 );
156

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-02-12 17:26    [W:0.174 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site