Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH 2/4] powerpc/vas: Fix cleanup when VAS is not configured | Date | Mon, 12 Feb 2018 16:23:50 +1100 |
| |
Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> writes:
> When VAS is not configured in the system, make sure to remove > the VAS debugfs directory and unregister the platform driver. > > Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> ... > diff --git a/arch/powerpc/platforms/powernv/vas.c b/arch/powerpc/platforms/powernv/vas.c > index aebbe95..f83e27d8 100644 > --- a/arch/powerpc/platforms/powernv/vas.c > +++ b/arch/powerpc/platforms/powernv/vas.c > @@ -169,8 +169,11 @@ static int __init vas_init(void) > found++; > } > > - if (!found) > + if (!found) { > + platform_driver_unregister(&vas_driver); > + vas_cleanup_dbgdir(); > return -ENODEV; > + }
The better patch would be to move the call to vas_init_dbgdir() down here, where we know we have successfully registered the driver.
cheers
| |