lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 116/136] staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl
    3.16.54-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Viktor Slavkovic <viktors@google.com>

    commit 443064cb0b1fb4569fe0a71209da7625129fb760 upstream.

    A lock-unlock is missing in ASHMEM_SET_SIZE ioctl which can result in a
    race condition when mmap is called. After the !asma->file check, before
    setting asma->size, asma->file can be set in mmap. That would result in
    having different asma->size than the mapped memory size. Combined with
    ASHMEM_UNPIN ioctl and shrinker invocation, this can result in memory
    corruption.

    Signed-off-by: Viktor Slavkovic <viktors@google.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    [bwh: Backported to 3.16: adjust context]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/staging/android/ashmem.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/staging/android/ashmem.c
    +++ b/drivers/staging/android/ashmem.c
    @@ -758,10 +758,12 @@ static long ashmem_ioctl(struct file *fi
    break;
    case ASHMEM_SET_SIZE:
    ret = -EINVAL;
    + mutex_lock(&ashmem_mutex);
    if (!asma->file) {
    ret = 0;
    asma->size = (size_t) arg;
    }
    + mutex_unlock(&ashmem_mutex);
    break;
    case ASHMEM_GET_SIZE:
    ret = asma->size;
    \
     
     \ /
      Last update: 2018-02-11 05:53    [W:4.076 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site