lkml.org 
[lkml]   [2018]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 077/136] IB/mlx5: Assign send CQ and recv CQ of UMR QP
    3.16.54-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Majd Dibbiny <majd@mellanox.com>

    commit 31fde034a8bd964a5c7c1a5663fc87a913158db2 upstream.

    The UMR's QP is created by calling mlx5_ib_create_qp directly, and
    therefore the send CQ and the recv CQ on the ibqp weren't assigned.

    Assign them right after calling the mlx5_ib_create_qp to assure
    that any access to those pointers will work as expected and won't
    crash the system as might happen as part of reset flow.

    Fixes: e126ba97dba9 ("mlx5: Add driver for Mellanox Connect-IB adapters")
    Signed-off-by: Majd Dibbiny <majd@mellanox.com>
    Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
    Signed-off-by: Leon Romanovsky <leon@kernel.org>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/infiniband/hw/mlx5/main.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/infiniband/hw/mlx5/main.c
    +++ b/drivers/infiniband/hw/mlx5/main.c
    @@ -1164,6 +1164,8 @@ static int create_umr_res(struct mlx5_ib
    qp->real_qp = qp;
    qp->uobject = NULL;
    qp->qp_type = MLX5_IB_QPT_REG_UMR;
    + qp->send_cq = init_attr->send_cq;
    + qp->recv_cq = init_attr->recv_cq;

    attr->qp_state = IB_QPS_INIT;
    attr->port_num = 1;
    \
     
     \ /
      Last update: 2018-02-11 05:47    [W:4.062 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site