Messages in this thread | | | Date | Thu, 1 Feb 2018 10:05:53 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH] x86/mm: Rename flush_tlb_single() and flush_tlb_one() |
| |
On Wed, Jan 31, 2018 at 08:03:10AM -0800, Andy Lutomirski wrote: > flush_tlb_single() and flush_tlb_one() sound almost identical, but > they really mean "flush one user translation" and "flush one kernel > translation". Rename them to flush_tlb_one_user() and > flush_tlb_one_kernel() to make the semantics more obvious. > > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Dave Hansen <dave.hansen@intel.com> > Cc: Borislav Petkov <bpetkov@suse.de> > Cc: Kees Cook <keescook@google.com> > Cc: Hugh Dickins <hughd@google.com> > Cc: Brian Gerst <brgerst@gmail.com> > Cc: Josh Poimboeuf <jpoimboe@redhat.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Eduardo Valentin <eduval@amazon.com> > Cc: Will Deacon <will.deacon@arm.com> > Cc: Linux-MM <linux-mm@kvack.org> > Signed-off-by: Andy Lutomirski <luto@kernel.org> > --- > > I was looking at some PTI-related code, and the flush-one-address code > is unnecessarily hard to understand because the names of the helpers are > uninformative. This came up during PTI review, but no one got around to > doing it.
Right, got as far as making it consistent and putting a comment on :-)
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
| |