Messages in this thread | | | Date | Thu, 1 Feb 2018 12:03:06 +0000 | From | James Hogan <> | Subject | Re: [PATCH] MIPS: ftrace: Remove pointer comparison to 0 in prepare_ftrace_return |
| |
On Wed, Jan 17, 2018 at 12:31:57PM +0100, Mathieu Malaterre wrote: > Replace pointer comparison to 0 with NULL in prepare_ftrace_return > to improve code readability. Identified with coccinelle script > 'badzero.cocci'. > > Signed-off-by: Mathieu Malaterre <malat@debian.org>
I've applied to my 4.16 branch,
Thanks James
> --- > arch/mips/kernel/ftrace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c > index 99285be0e088..7f3dfdbc3657 100644 > --- a/arch/mips/kernel/ftrace.c > +++ b/arch/mips/kernel/ftrace.c > @@ -361,7 +361,7 @@ void prepare_ftrace_return(unsigned long *parent_ra_addr, unsigned long self_ra, > * If fails when getting the stack address of the non-leaf function's > * ra, stop function graph tracer and return > */ > - if (parent_ra_addr == 0) > + if (parent_ra_addr == NULL) > goto out; > #endif > /* *parent_ra_addr = return_hooker; */ > -- > 2.11.0 > > [unhandled content-type:application/pgp-signature] | |