lkml.org 
[lkml]   [2018]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 273/328] ax88179_178a: Check for supported Wake-on-LAN modes
    3.16.62-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    commit 5ba6b4aa9a410c5e2c6417df52b5e2118ea9b467 upstream.

    The driver currently silently accepts unsupported Wake-on-LAN modes
    (other than WAKE_PHY or WAKE_MAGIC) without reporting that to the user,
    which is confusing.

    Fixes: e2ca90c276e1 ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/usb/ax88179_178a.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/net/usb/ax88179_178a.c
    +++ b/drivers/net/usb/ax88179_178a.c
    @@ -506,6 +506,9 @@ ax88179_set_wol(struct net_device *net,
    struct usbnet *dev = netdev_priv(net);
    u8 opt = 0;

    + if (wolinfo->wolopts & ~(WAKE_PHY | WAKE_MAGIC))
    + return -EINVAL;
    +
    if (wolinfo->wolopts & WAKE_PHY)
    opt |= AX_MONITOR_MODE_RWLC;
    if (wolinfo->wolopts & WAKE_MAGIC)
    \
     
     \ /
      Last update: 2018-12-09 23:03    [W:3.550 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site