Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [RFC PATCH v2 2/2] mwifiex: add NL80211_STA_INFO_RX_BITRATE support | Date | Fri, 07 Dec 2018 12:50:25 +0200 |
| |
Brian Norris <briannorris@chromium.org> writes:
> Comparing the existing TX_BITRATE parsing code (in > mwifiex_parse_htinfo()) with the RX bitrate histograms in debugfs.c, it > appears that the rxpd_rate and rxpd_htinfo fields have the same format. > At least, they give reasonable results when I parse them this way. > > So this patch adds support for RX_BITRATE to our station info dump. > > Along the way, I add legacy bitrate parsing into the same function, > using the debugfs code (mwifiex_histogram_read() and > mwifiex_adjust_data_rate()) as reference. > > Additionally, to satisfy the requirements of > NL80211_STA_INFO_RX_BITRATE, I skip logging the bitrate of multicast > packets. This shouldn't add a lot of overhead to the RX path, as there > are already several similar 802.3 header checks in this same codepath. > We can also bias the branch behavior to favor unicast, as that's the > common performance-sensitive case. > > I'd consider this support somewhat experimental, as I have zero > documentation from Marvell. But the existing driver code gives me good > reason to think this is correct. > > I've tested this on a few different 802.11{a,b,g,n,ac} networks, and the > reported bitrates look good to me. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > RFC: I'd appreciate it if someone from Marvell could double check my work > here.
BTW, if we don't hear anything from Marvell I'm going to apply these anyway.
-- Kalle Valo
| |