Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 4 Dec 2018 15:40:24 -0800 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v6 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm |
| |
On Tue, Dec 04, 2018 at 09:21:35AM +0100, Roberto Sassu wrote: > Currently the TPM driver allows other kernel subsystems to read only the > SHA1 PCR bank. This patch modifies the parameters of tpm_pcr_read() and > tpm2_pcr_read() to pass a tpm_digest structure, which contains the desired > hash algorithm. Also, since commit 125a22105410 ("tpm: React correctly to > RC_TESTING from TPM 2.0 self tests") removed the call to tpm2_pcr_read(), > the new parameter is expected to be always not NULL. > > Due to the API change, IMA functions have been modified. > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > Acked-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Mimi, Nayna, can you help with testing this (because of the IMA change)?
/Jarkko
| ![\](/images/icornerr.gif) |