lkml.org 
[lkml]   [2018]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 1/9] clkdev: add managed clkdev lookup registration
    Hello Russell,

    Thanks for the review. I do appreciate this. I'll send out v6 where I'll
    have these fixed =)

    On Mon, Dec 03, 2018 at 06:06:12PM +0000, Russell King - ARM Linux wrote:
    > > +static int devm_clk_match_clkdev(struct device *dev, void *res, void *data)
    > > +{
    > > + struct clk_lookup **l = res;
    > > +
    > > + if (!l || !*l) {
    > > + WARN_ON(!l || !*l);
    >
    > How can "l" be NULL here? How can *l be NULL?

    I really don't know if there is any "sane" way to end up having the
    devres data NULLed. I admit I looked an example on how others had
    implemented the match. These checks were present in devm_clk_match
    and devm_regmap_irq_chip_match so I assumed there is a way to end up
    having NULL there. Thus I played safe. OTOH it seems that for example
    devm_hwmon_match does omit these checks and I really don't see right
    away why the dr->data would be NULL. So I'll remove the check.

    Br,
    Matti Vaittinen

    >
    > --
    > RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
    > FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
    > According to speedtest.net: 11.9Mbps down 500kbps up

    --
    Matti Vaittinen
    ROHM Semiconductors

    ~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~

    \
     
     \ /
      Last update: 2018-12-04 09:04    [W:5.669 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site