Messages in this thread Patch in this message | | | From | Alexey Khoroshilov <> | Subject | [PATCH v2 1/2] media: tw9910: fix failure handling in tw9910_power_on() | Date | Sun, 30 Dec 2018 14:41:40 +0300 |
| |
If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> --- v2: reset pdn_gpio as well as Jacopo Mondi suggested.
drivers/media/i2c/tw9910.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c index a54548cc4285..0971f8a34afb 100644 --- a/drivers/media/i2c/tw9910.c +++ b/drivers/media/i2c/tw9910.c @@ -610,6 +610,11 @@ static int tw9910_power_on(struct tw9910_priv *priv) GPIOD_OUT_LOW); if (IS_ERR(priv->rstb_gpio)) { dev_info(&client->dev, "Unable to get GPIO \"rstb\""); + clk_disable_unprepare(priv->clk); + if (priv->pdn_gpio) { + gpiod_set_value(priv->pdn_gpio, 1); + usleep_range(500, 1000); + } return PTR_ERR(priv->rstb_gpio); } -- 2.7.4
| |