Messages in this thread | | | Date | Sat, 29 Dec 2018 13:49:23 +0100 | From | Stefan Agner <> | Subject | Re: [PATCH 1/2] ARM: Remove '-p' from LDFLAGS |
| |
On 05.12.2018 02:42, Nathan Chancellor wrote: > This option is not supported by lld: > > ld.lld: error: unknown argument: -p > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > that tree). Given that the lowest officially supported of binutils for > the kernel is 2.20, which was released in 2009, nobody needs this flag > around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p > linker flag") did the same for arm64. > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
There is another -p in arch/arm/boot/bootp/Makefile.
With that fixed:
Reviewed-by: Stefan Agner <stefan@agner.ch>
I guess you can send a v2 with this patch only, which then can make it in. Patch 2 seems to get fixed by adding --pic-veneer support in lld.
-- Stefan
> --- > arch/arm/Makefile | 2 +- > arch/arm/boot/compressed/Makefile | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 05a91d8b89f3..e2a0baf36766 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -10,7 +10,7 @@ > # > # Copyright (C) 1995-2001 by Russell King > > -LDFLAGS_vmlinux :=-p --no-undefined -X --pic-veneer > +LDFLAGS_vmlinux := --no-undefined -X --pic-veneer > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > KBUILD_LDFLAGS_MODULE += --be8 > diff --git a/arch/arm/boot/compressed/Makefile > b/arch/arm/boot/compressed/Makefile > index 1f5a5ffe7fcf..dcd07bd24b85 100644 > --- a/arch/arm/boot/compressed/Makefile > +++ b/arch/arm/boot/compressed/Makefile > @@ -131,8 +131,6 @@ endif > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > endif > -# ? > -LDFLAGS_vmlinux += -p > # Report unresolved symbol references > LDFLAGS_vmlinux += --no-undefined > # Delete all temporary local symbols
| |