Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 28 Dec 2018 15:39:58 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr |
| |
On Fri, 28 Dec 2018 09:48:34 +0100 Christoph Hellwig <hch@lst.de> wrote:
> On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote: > > Follow the kernel conventions, rename addr_in_gen_pool to > > gen_pool_has_addr. > > Which convention?
That symbols from subsystem foo should be called foo_*. Not uniformly observed by any means, but it is a thing.
> The old name certainly looks more sensible to me.
It does read better, but it's rather a standout in this case:
q:/usr/src/25> grep EXPORT_SYMBOL lib/genalloc.c EXPORT_SYMBOL(gen_pool_create); EXPORT_SYMBOL(gen_pool_add_virt); EXPORT_SYMBOL(gen_pool_virt_to_phys); EXPORT_SYMBOL(gen_pool_destroy); EXPORT_SYMBOL(gen_pool_alloc); EXPORT_SYMBOL(gen_pool_alloc_algo); EXPORT_SYMBOL(gen_pool_dma_alloc); EXPORT_SYMBOL(gen_pool_free); EXPORT_SYMBOL(gen_pool_for_each_chunk); EXPORT_SYMBOL(addr_in_gen_pool); EXPORT_SYMBOL_GPL(gen_pool_avail); EXPORT_SYMBOL_GPL(gen_pool_size); EXPORT_SYMBOL(gen_pool_set_algo); EXPORT_SYMBOL(gen_pool_first_fit); EXPORT_SYMBOL(gen_pool_first_fit_align); EXPORT_SYMBOL(gen_pool_fixed_alloc); EXPORT_SYMBOL(gen_pool_first_fit_order_align); EXPORT_SYMBOL(gen_pool_best_fit); EXPORT_SYMBOL_GPL(gen_pool_get); EXPORT_SYMBOL(devm_gen_pool_create); EXPORT_SYMBOL_GPL(of_gen_pool_get);
| ![\](/images/icornerr.gif) |