Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 1/2 v3] kdump: add the vmcoreinfo documentation | From | lijiang <> | Date | Wed, 26 Dec 2018 14:14:40 +0800 |
| |
在 2018年12月26日 11:36, Dave Young 写道: > On 12/26/18 at 11:24am, Dave Young wrote: >>>>> + >>>>> +KERNEL_IMAGE_SIZE >>>>> +================= >>>>> +The size of 'KERNEL_IMAGE_SIZE', currently unused. >>>> >>>> So remove? >>>> >>> >>> I'm not sure whether it should be removed, so i keep it. >> >> Just remove it. It was added by Baoquan for KASLR issues, later >> makedumpfile reverted the userspace part and added other implementation. >> >> In case old makedumpfile does not support new kernel, it has some kernel >> versions support list in code, thus no worry about the compatibility >> issue. > > Ah, it is not unused actually, clone crash tool git: > $ git grep KERNEL_IMAGE_SIZE > x86_64.c: if ((string = pc->read_vmcoreinfo("NUMBER(KERNEL_IMAGE_SIZE)"))) { > > So in the documentation, the use cases of crash tool should also be > covered. >
Sure, maybe only this one was ignored.
I will improve this variable in the documentation.
> Lianbo, it would be good to cc Dave and Kazu for these patches, could > you cc them in your next post? >
Yes, i will add Dave and Kazu, and also resend patch v4.
Thanks.
>> >> Thanks >> Dave > > Thanks > Dave >
| ![\](/images/icornerr.gif) |