lkml.org 
[lkml]   [2018]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] clk: dove: fix refcount leak in dove_clk_init()
Date
Hi Yangtao,

On mer., déc. 26 2018, Yangtao Li <tiny.windzz@gmail.com> wrote:

> The of_find_compatible_node() returns a node pointer with refcount
> incremented, but there is the lack of use of the of_node_put() when
> done. Add the missing of_node_put() to release the refcount.

Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>

Thanks,

Gregory

>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/clk/mvebu/dove.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/mvebu/dove.c b/drivers/clk/mvebu/dove.c
> index e0dd99f36bf4..0bd09d33f9cf 100644
> --- a/drivers/clk/mvebu/dove.c
> +++ b/drivers/clk/mvebu/dove.c
> @@ -188,10 +188,14 @@ static void __init dove_clk_init(struct device_node *np)
>
> mvebu_coreclk_setup(np, &dove_coreclks);
>
> - if (ddnp)
> + if (ddnp) {
> dove_divider_clk_init(ddnp);
> + of_node_put(ddnp);
> + }
>
> - if (cgnp)
> + if (cgnp) {
> mvebu_clk_gating_setup(cgnp, dove_gating_desc);
> + of_node_put(cgnp);
> + }
> }
> CLK_OF_DECLARE(dove_clk, "marvell,dove-core-clock", dove_clk_init);
> --
> 2.17.0
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

\
 
 \ /
  Last update: 2018-12-26 16:48    [W:0.050 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site