Messages in this thread | | | From | Liang Yang <> | Subject | Re: [PATCH RESEND v8 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller | Date | Tue, 25 Dec 2018 15:55:16 +0800 |
| |
Hi Martin, On 2018/12/23 1:07, Martin Blumenstingl wrote: > Hi Jianxin, Hi Liang, > > On Fri, Dec 21, 2018 at 12:45 PM Jianxin Pan <jianxin.pan@amlogic.com> wrote: >> >> From: Liang Yang <liang.yang@amlogic.com> >> >> Add initial support for the Amlogic NAND flash controller which found >> in the Meson-GXBB/GXL/AXG SoCs. >> >> Signed-off-by: Liang Yang <liang.yang@amlogic.com> >> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com> >> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com> >> --- >> drivers/mtd/nand/raw/Kconfig | 10 + >> drivers/mtd/nand/raw/Makefile | 1 + >> drivers/mtd/nand/raw/meson_nand.c | 1468 +++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1479 insertions(+) >> create mode 100644 drivers/mtd/nand/raw/meson_nand.c >> >> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig >> index 1a55d3e..d05ff20 100644 >> --- a/drivers/mtd/nand/raw/Kconfig >> +++ b/drivers/mtd/nand/raw/Kconfig >> @@ -541,4 +541,14 @@ config MTD_NAND_TEGRA >> is supported. Extra OOB bytes when using HW ECC are currently >> not supported. >> >> +config MTD_NAND_MESON >> + tristate "Support for NAND controller on Amlogic's Meson SoCs" >> + depends on ARCH_MESON || COMPILE_TEST >> + depends on COMMON_CLK_AMLOGIC >> + select COMMON_CLK_REGMAP_MESON > I believe that "depends on COMMON_CLK_AMLOGIC" and "select > COMMON_CLK_REGMAP_MESON" are not necessary: > the driver should build fine without them because it's only > interfacing with the common clock framework. > the common clock framework is enabled by ARCH_MESON and for the > COMPILE_TEST case the common clock framework provides stub > implementations inside the headers. > >> + select MFD_SYSCON >> + help >> + Enables support for NAND controller on Amlogic's Meson SoCs. >> + This controller is found on Meson GXBB, GXL, AXG SoCs. > you are explicitly mentioning GXBB here but you don't add a "GXBB" compatible. > I suggest to shorten this sentence ("This controller is found on Meson > SoCs.") because this driver can also support the 32-bit > Meson8/Meson8b/Meson8m2 SoCs with minor adjustments. > we only have tested on Meson GXL and AXG platform, but it should support GXBB and Meson8/Meson8b/Meson8m2 and the differences between these controllers are only the base address of register and some SD_EMMC_CLOCK control bits.
i think "This controller is found on Meson SoCs." is ok.
> Regards > Martin > > . >
| |