lkml.org 
[lkml]   [2018]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net/net_namespace: Check the return value of register_pernet_subsys()
From
Date
On 24.12.2018 04:42, Aditya Pakki wrote:
> In net_ns_init(), register_pernet_subsys() could fail while registering
> network namespace subsystems. The fix checks the return value and
> sends a panic() on failure.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>

Reviewed-by: Kirill Tkhai <ktkhai@virtuozzo.com>

> ---
> net/core/net_namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index fefe72774aeb..af8849a7a9c3 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -917,7 +917,8 @@ static int __init net_ns_init(void)
> init_net_initialized = true;
> up_write(&pernet_ops_rwsem);
>
> - register_pernet_subsys(&net_ns_ops);
> + if (register_pernet_subsys(&net_ns_ops))
> + panic("Could not register network namespace subsystems");
>
> rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL,
> RTNL_FLAG_DOIT_UNLOCKED);
>

\
 
 \ /
  Last update: 2018-12-24 10:36    [W:0.034 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site