Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH][next] smack: fix two memory leaks in smack_add_opt | From | Colin Ian King <> | Date | Sat, 22 Dec 2018 23:03:00 +0000 |
| |
On 22/12/2018 19:34, Al Viro wrote: > On Sat, Dec 22, 2018 at 12:27:50PM +0000, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> Currently if s is null or when returning via the error exit label >> out_opt_err leaks of the allocated opts can occur. Fix the leak >> on the null s case by checking s is null before the allocation. Fix >> the leak on the exit path by checking if opts was allocated by >> kfree'ing opts. >> >> Detected by CoverityScan, CID#1475953 ("Resource leak") >> >> Fixes: b2130173efae ("smack: take the guts of smack_parse_opts_str() into a new helper") >> Signed-off-by: Colin Ian King <colin.king@canonical.com> > > There's a better fix in local tree, will go into -next tonight. > OK, sounds good to me. Thanks
Colin
| ![\](/images/icornerr.gif) |