Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 21 Dec 2018 11:45:47 -0800 | From | Matthew Wilcox <> | Subject | Re: [PATCH 03/12] __wr_after_init: generic header |
| |
On Fri, Dec 21, 2018 at 11:38:16AM -0800, Nadav Amit wrote: > > On Dec 19, 2018, at 1:33 PM, Igor Stoppa <igor.stoppa@gmail.com> wrote: > > > > +static inline void *wr_memset(void *p, int c, __kernel_size_t len) > > +{ > > + return __wr_op((unsigned long)p, (unsigned long)c, len, WR_MEMSET); > > +} > > What do you think about doing something like: > > #define __wr __attribute__((address_space(5))) > > And then make all the pointers to write-rarely memory to use this attribute? > It might require more changes to the code, but can prevent bugs.
I like this idea. It was something I was considering suggesting.
| ![\](/images/icornerr.gif) |