lkml.org 
[lkml]   [2018]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/2] gpio: Add Cadence GPIO driver
On Tue, Dec 18, 2018 at 3:06 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> wt., 18 gru 2018 o 14:54 Janek Kotas <jank@cadence.com> napisał(a):

> > I can reimplement the driver using regmap, but It seems in such case
> > I won’t be able to use the Generic GPIO Infrastructure, would I?
> > So I would need to provide functions for setting direction, etc.
> > I think it would make the driver code bigger.
>
> Indeed. If anything: gpio-mmio would need to be converted to using regmap.

Ouch, let's go with this for now.

I think for gpio-mmio we have two new cases we really need to cover:
- port-mapped I/O (x86)
- regmap I/O

Augmenting gpio-mmio for these could probably strip out quite a
bunch of code from several drivers.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-12-21 11:38    [W:0.066 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site