Messages in this thread | | | Date | Fri, 21 Dec 2018 09:09:12 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v5 2/7] mfd / platform: cros_ec: move lightbar attributes to its own driver |
| |
On Wed, 12 Dec 2018, Enric Balletbo i Serra wrote:
> The entire way how cros sysfs attibutes are created is broken. > cros_ec_lightbar should be its own driver and its attributes should be > associated with a lightbar driver not the mfd driver. In order to retain > the path, the lightbar attributes are attached to the cros_class. > > The patch also adds the sysfs documentation. > > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > > Changes in v5: None > Changes in v4: > - Use <ec-device-name> instead <cros-ec> in documentation. > > Changes in v3: > - Removed unneded check for ec_dev. > > Changes in v2: > - Removed the two exported functions to attach/detach to the cros_class. > - Use dev_warn instead of dev_err when adding the lightbar. > > ...sfs-class-chromeos-driver-cros-ec-lightbar | 74 +++++++++++++++ > drivers/mfd/cros_ec_dev.c | 24 ++--- > drivers/mfd/cros_ec_dev.h | 6 --
> drivers/platform/chrome/Kconfig | 11 +++ > drivers/platform/chrome/Makefile | 3 +- > drivers/platform/chrome/cros_ec_lightbar.c | 95 ++++++++++++++----- > include/linux/mfd/cros_ec.h | 1 -
For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |