lkml.org 
[lkml]   [2018]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] mtd: remove DEBUGFS_RO_ATTR()
On Sun, Dec 2, 2018 at 4:15 PM Boris Brezillon
<boris.brezillon@bootlin.com> wrote:
>
> Looks like getting rid of DEBUGFS_RO_ATTR() is just one of the change
> you do. I think you should change the subject line:
>
> "mtd: use DEFINE_SHOW_ATTRIBUTE() instead of open-coding it"
>
> This way it covers all of your changes.
>
> On Sun, 2 Dec 2018 02:32:02 -0500
> Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> > We already have the DEFINE_SHOW_ATTRIBUTE.There is no need to define
>
> ^ missing space
>
> > such a macro,so remove DEBUGFS_RO_ATTR.Also use DEFINE_SHOW_ATTRIBUTE
>
> ^ here as well
>
> > to simplify some code.
>
> If you go for the new subject line, you'll have to change this commit
> message.
How about the newer?

MBR,
Yangtao

\
 
 \ /
  Last update: 2018-12-02 09:36    [W:0.678 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site